Enable Enum Imports and Synchronize Paths #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since CoreFoundation on Windows doesn't compile with cplusplus and doesn't have objc_fixed_enum, it goes down the wrong path for enums and defaults them to a 32 bit backing. This causes CFDateComponentUndefined to be 32bit value which then doesn't match NSDateComponentUndefined which is an Int64.
|
@swift-ci please test |
|
I'm in favour of this, this looks good to me. Lets just poke @millenomi and @parkera before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows wasn't going down the 64bit enum path in CoreFoundation which caused CFDateComponentUndefined to be 32bit and NSDateComponentUndefined and thus not match. Since changing this causes the enum behavior to change, I've rebased #1729 and included it in this pull.