[5.3] OperationQueue fixes #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some issues in current implementation. To keep things simple, I'd like to extend test coverage of problem area first. Not all of new tests are expected to fail, but I find them useful to have. Co-authored-by: Andrew Druk <adruk@readdle.com> Co-authored-by: Anton Pogonets <apogonets@readdle.com> (cherry picked from commit d6cb1ee)
This fixes typos in code responsible for counting operations in queue. (cherry picked from commit d8c2cfa)
- prevent releasing of stored value in `Operation._queue` property getter - balance retain count after current queue removed from thread-specific storage - make test_OperationWaitUntilFinished stable - extend test_OperationCount (cherry picked from commit 6257faa)
|
@swift-ci please test |
|
Will this make it into 5.3? @parkera @millenomi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rollup of three OperationQueue fixes, #2776 #2777 #2779
This is done as one PR as the some tests are disabled then enabled and the commits overlap otherwise.