JSON Encoding based on JSONValue #2987
Conversation
|
@swift-ci test |
| @inline(__always) func setObject(for key: String) -> Object { | ||
| switch self.dict[key] { | ||
| case .encoder: | ||
| preconditionFailure("For key \"\(key)\" an encoder has already been created.") |
There was a problem hiding this comment.
is it safe to precondition here (and other spot around this)? i.e no user action can cause this?
There was a problem hiding this comment.
This shall lead to a crash because of a programmer error and closely mimics the Darwin Foundation behavior. It is not possible to create a json array or a json dictionary at the same time for the same key.
| if #available(macOS 10.12, iOS 10.0, watchOS 3.0, tvOS 10.0, *) { | ||
| return .string(_iso8601Formatter.string(from: date)) | ||
| } else { | ||
| fatalError("ISO8601DateFormatter is unavailable on this platform.") |
There was a problem hiding this comment.
hmmm I think we can use regular formatter with right pattern to achieve iso8601, no?
| } | ||
| bytes.append(._closebracket) | ||
| case .object(let dict): | ||
| if #available(OSX 10.13, *), options.contains(.sortedKeys) { |
There was a problem hiding this comment.
ditto, should be supported on linux afaik
Sources/Foundation/JSONEncoder.swift
Outdated
| case nestedArray(Array) | ||
| case nestedObject(Object) | ||
|
|
||
| class Array { |
There was a problem hiding this comment.
Could we name this something more specific? I get it's a private type but that case nestedArray(Array) threw me for a second.
fabianfett
force-pushed
the
ff-json-encoding
branch
from
c96f6be
to
8660270
Compare
|
@swift-ci test |
|
cc @millenomi |
After #2966 and #2985, this is the last step to make JSON Encoding and Decoding much more performant on Linux.