Synchronize Decimal overlay and corelibs-foundation implementations
#3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwu
changed the title
Decimal overlay and corelibs-foundation implementations.Decimal overlay and corelibs-foundation implementations
|
@swift-ci test |
|
@swift-ci test Linux |
spevans
approved these changes
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements were made to the corelibs implementation of
Decimalover the years which have not been in sync with the overlay. Most evidently, #2926 resolving SR-13837 and #2574 implementinginit?(exactly:)are lacking from the overlay. Credit goes entirely to @spevans for actually implementing these fixes.This PR re-aligns the two implementations. Only very minor adjustments are made to the corelibs implementation, mostly where it uses private APIs that do not exist in the overlay, to better keep the two implementations in sync.
A minor change is made to both implementations in terms of diagnostic messages: where we state that
Decimaldoes not "yet" conform toFloatingPoint, the "yet" is deleted because it misleadingly suggests a conformance that is not the plan of record.