Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @noescape to Synchronous Enumeration, Predicate, and Comparator Blocks #4

Closed
wants to merge 3 commits into from

Conversation

Adlai-Holler
Copy link
Contributor

No description provided.

@parkera
Copy link
Member

parkera commented Dec 4, 2015

This is an interesting case, because if we do this then the API is going to be different between Darwin and Swift, but we want to make sure that we stay consistent.

However, I think @noescape is the right answer for these APIs, so we should figure out a way to do this. clang has an attribute to express what we want in C/Objective-C: __attribute__((noescape)).

Since we can't fix up the Darwin Foundation headers at the same time as we do this, the best approach is going to be to use something like API notes to fix up the Foundation SDK on Darwin so it matches. Do we have support in API notes for @noescape yet?

@parkera
Copy link
Member

parkera commented Dec 5, 2015

Following up on this - we think this is a great idea. Since this pull request contains an API change, let’s follow the Swift evolution process, starting with discussing the idea on the swift-evolution and swift-corelibs-dev lists.

@parkera parkera closed this Dec 5, 2015
@Adlai-Holler
Copy link
Contributor Author

@parkera OK cool.

atrick pushed a commit to atrick/swift-corelibs-foundation that referenced this pull request Jan 12, 2021
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Apr 29, 2021
Revert "[xctest] disable the test due to apple#304"
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Oct 11, 2023
[pull] swiftwasm from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants