fileprivate updates
#413
Closed
fileprivate updates
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was just a find/replace, right? Can we wait on this until after we merge the gigantic swift-3 branch? |
|
Essentially. I couldn't find you guys using inner classes and any chicanery that would require full private cases like SwiftPM. |
|
I think we have some on the swift-3 branch, so we'll need to revisit this after merge. |
|
Definitely. The proposal needs to be amended in the meantime, so the timing is perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Foundation to use the new
fileprivateaccess control level to ensure compatibility with SE-0025 and apple/swift#3000.