Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Add an implementation for the missing bzero function #4595

Merged
merged 1 commit into from May 26, 2022

Conversation

bnbarham
Copy link
Contributor

Rebranch is currently failing with a missing declaration for bzero on
Windows. Add a definition as in other uses of bzero.

Rebranch is currently failing with a missing declaration for `bzero` on
Windows. Add a definition as in other uses of `bzero`.
@bnbarham
Copy link
Contributor Author

@swift-ci please test

Copy link
Collaborator

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I think we should do a cross-repo test as well before merging to ensure that we have all the cases.

@bnbarham
Copy link
Contributor Author

Yep, started in apple/swift#59062

@bnbarham
Copy link
Contributor Author

Looks like we got through the swift-corelibs-foundation Windows build :)!

@compnerd
Copy link
Collaborator

We actually got through the test suite even!

@compnerd compnerd merged commit dc74daf into apple:main May 26, 2022
@bnbarham bnbarham deleted the fix-windows-bzero-failure branch May 26, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants