[wasm] Add objc_retainAutoreleasedReturnValue definition #4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not hugely keen on propagating this hack into |
|
I think the compiler change needed here is literally a three line fix (I'm just trying it now to see). |
|
Hopefully apple/swift#72011 will fix this problem and then we won't need this (and can delete the corresponding code from |
|
This workaround is no longer necessary! Thank you @al45tair! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is usually provided by libdispatch, but for platforms where libdispatch is unavailable at this moment, we need to provide it in CF as we do for BlocksRuntime.