Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify contents of the file attributes dictionary #5

Closed
wants to merge 0 commits into from
Closed

Verify contents of the file attributes dictionary #5

wants to merge 0 commits into from

Conversation

bolshedvorsky
Copy link
Contributor

No description provided.

@parkera
Copy link
Member

parkera commented Dec 4, 2015

This one didn't compile for me on Ubuntu 14.04:

TestFoundation/TestNSFileManager.swift:121:13: error: cannot invoke 'XCTAssertEqual' with an argument list of type '(NSString, String)'
            XCTAssertEqual(fileType!, NSFileTypeRegular)
            ^

There are actually some issues with the NSFileManager API itself that I think we need to fix up in addition to adding this test (which is a good idea, btw).

public func attributesOfItemAtPath(path: String) throws -> [String : AnyObject]
  1. The return type should be [String : Any](and we need to mark it as experimental since it will then be slightly different than Darwin, although compatible)
  2. The implementation should be creating String instead of NSString. It should still use NSNumber and NSDate though.

Would you be willing to take a look at these issues and provide a new patch?

@bolshedvorsky
Copy link
Contributor Author

Yes I will take a look at these issues and I will provide a new patch.

atrick pushed a commit to atrick/swift-corelibs-foundation that referenced this pull request Jan 12, 2021
Add "Document Symbols" to status feature list
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants