Enable NSLocale keyed archiving unit tests #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
The build timed out because of |
|
@swift-ci Please test |
itaiferber
added a commit
to itaiferber/swift-corelibs-foundation
that referenced
this pull request
Aug 25, 2016
* Archive NSLocale identifier as NSString * Override isEqual for NSLocale * Uncomment NSLocale archiving test
itaiferber
added a commit
that referenced
this pull request
Aug 26, 2016
* Archive NSLocale identifier as NSString * Override isEqual for NSLocale * Uncomment NSLocale archiving test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSLocale'sencode(with:)encodes the locale's identifier as aCFString, which causes a crash inNSKeyedArchiver's_haveVisitedref map, sinceCFStringcannot be forcibly cast toAnyHashable. Encoding the identifier as anNSStringfixes the issue.In decoding, a different
NSLocaleinstance is returned. SinceNSLocaleno longer has value semantics (which were ported toLocale), it needs anisEqualimplementation to compare twoNSLocaleinstances as equal.These changes combined allows us to uncomment the keyed archiving test and have it pass.