String: prevent executable stacks on GNU targets #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of the hand written assembly files could potentially introduce executable stacks. Since these files do not require the executable stacks, ensure that we add the special marker to indicate that executable stacks are not required.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
CC @phausler |
|
@swift-ci Please test and merge |
|
@swift-ci please test and merge |
|
pending CI being up and running properly this looks good to me |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the hand written assembly files could potentially introduce
executable stacks. Since these files do not require the executable stacks,
ensure that we add the special marker to indicate that executable stacks are not
required.