Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Array.reserveCapacity in NSArray/NSMutableArray #9

Merged
merged 1 commit into from Dec 3, 2015
Merged

Use Array.reserveCapacity in NSArray/NSMutableArray #9

merged 1 commit into from Dec 3, 2015

Conversation

Adlai-Holler
Copy link
Contributor

No description provided.

phausler added a commit that referenced this pull request Dec 3, 2015
@phausler
Merge pull request #9 from Adlai-Holler/InitWithCapacity
c58eed6 
Use Array.reserveCapacity in NSArray/NSMutableArray
@phausler phausler merged commit c58eed6 into apple:master Dec 3, 2015
@Adlai-Holler
Copy link
Contributor Author

Whoa! Hey Philippe! Look forward to working with you on this man.

@Adlai-Holler Adlai-Holler deleted the InitWithCapacity branch December 3, 2015 21:05
johnno1962 added a commit to johnno1962d/swift-corelibs-foundation that referenced this pull request Feb 16, 2018
@johnno1962
Fix for when key is a String rather than NSString. Otherwise you can …
598eccb 
…get the following crash:

Could not cast value of type 'Swift.AnyHashable' (0x1027b3b10) to 'SwiftFoundation.NSObject' (0x101a56668).
2018-02-16 14:30:46.355774+0000 TestFoundation[7306:8715333] Could not cast value of type 'Swift.AnyHashable' (0x1027b3b10) to 'SwiftFoundation.NSObject' (0x101a56668).
(lldb) up
frame apple#9: 0x000000010165b114 SwiftFoundation`NSMutableDictionary.subscript.setter(newValue=some, key=Swift.AnyHashable @ 0x00007fff5fbfcd88, self=0x000060800e181fe0) at NSDictionary.swift:649
   646 	        }
   647 	        set {
   648 	            if let val = newValue {
-> 649 	                �[4ms�[0metObject(val, forKey: key)
   650 	            } else {
   651 	                removeObject(forKey: key)
   652 	            }
(lldb) up
frame apple#10: 0x00000001004c0443 TestFoundation`static Dictionary.twEncode(data=TestFoundation.TwoWayMirror @ 0x00007fff5fbfce00, self=[Key : Value]) at TwoWayMirror.swift:386
   383 	            #if os(Linux)
   384 	            let key = NSString(string: key as! String)
   385 	            #endif
-> 386 	            dict[key] �[4m=�[0m TwoWayMirror.encode(mirror: &mirror)
   387 	        }
   388 	        return dict
   389 	    }
(lldb)
johnno1962 added a commit to johnno1962d/swift-corelibs-foundation that referenced this pull request Feb 19, 2018
@johnno1962
Fix for when key is a String rather than NSString. Otherwise you can …
35df019 
…get the following crash:

Could not cast value of type 'Swift.AnyHashable' (0x1027b3b10) to 'SwiftFoundation.NSObject' (0x101a56668).
2018-02-16 14:30:46.355774+0000 TestFoundation[7306:8715333] Could not cast value of type 'Swift.AnyHashable' (0x1027b3b10) to 'SwiftFoundation.NSObject' (0x101a56668).
(lldb) up
frame apple#9: 0x000000010165b114 SwiftFoundation`NSMutableDictionary.subscript.setter(newValue=some, key=Swift.AnyHashable @ 0x00007fff5fbfcd88, self=0x000060800e181fe0) at NSDictionary.swift:649
   646 	        }
   647 	        set {
   648 	            if let val = newValue {
-> 649 	                �[4ms�[0metObject(val, forKey: key)
   650 	            } else {
   651 	                removeObject(forKey: key)
   652 	            }
(lldb) up
frame apple#10: 0x00000001004c0443 TestFoundation`static Dictionary.twEncode(data=TestFoundation.TwoWayMirror @ 0x00007fff5fbfce00, self=[Key : Value]) at TwoWayMirror.swift:386
   383 	            #if os(Linux)
   384 	            let key = NSString(string: key as! String)
   385 	            #endif
-> 386 	            dict[key] �[4m=�[0m TwoWayMirror.encode(mirror: &mirror)
   387 	        }
   388 	        return dict
   389 	    }
(lldb)
johnno1962 added a commit to johnno1962d/swift-corelibs-foundation that referenced this pull request Feb 21, 2018
@johnno1962
Fix for when key is a String rather than NSString. Otherwise you can …
e426592 
…get the following crash:

Could not cast value of type 'Swift.AnyHashable' (0x1027b3b10) to 'SwiftFoundation.NSObject' (0x101a56668).
2018-02-16 14:30:46.355774+0000 TestFoundation[7306:8715333] Could not cast value of type 'Swift.AnyHashable' (0x1027b3b10) to 'SwiftFoundation.NSObject' (0x101a56668).
(lldb) up
frame apple#9: 0x000000010165b114 SwiftFoundation`NSMutableDictionary.subscript.setter(newValue=some, key=Swift.AnyHashable @ 0x00007fff5fbfcd88, self=0x000060800e181fe0) at NSDictionary.swift:649
   646 	        }
   647 	        set {
   648 	            if let val = newValue {
-> 649 	                �[4ms�[0metObject(val, forKey: key)
   650 	            } else {
   651 	                removeObject(forKey: key)
   652 	            }
(lldb) up
frame apple#10: 0x00000001004c0443 TestFoundation`static Dictionary.twEncode(data=TestFoundation.TwoWayMirror @ 0x00007fff5fbfce00, self=[Key : Value]) at TwoWayMirror.swift:386
   383 	            #if os(Linux)
   384 	            let key = NSString(string: key as! String)
   385 	            #endif
-> 386 	            dict[key] �[4m=�[0m TwoWayMirror.encode(mirror: &mirror)
   387 	        }
   388 	        return dict
   389 	    }
(lldb)
@johnno1962 johnno1962 mentioned this pull request Feb 21, 2018
Merged
atrick pushed a commit to atrick/swift-corelibs-foundation that referenced this pull request Jan 12, 2021
@benlangmuir
Merge pull request apple#9 from abdullahselek/master
4b77ff9 
Leave empty lines.
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Apr 29, 2021
@ddunbar
Merge pull request apple#9 from RLovelett/python-3
f8a66d1 
Python 3 compatibility
@troughton troughton mentioned this pull request May 5, 2022
Closed
@davezarzycki davezarzycki mentioned this pull request May 5, 2022
Open
@alblue alblue mentioned this pull request May 5, 2022
Closed
@phausler phausler mentioned this pull request Dec 27, 2015
Closed
@swift-ci swift-ci mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Adlai-Holler @phausler