Restore android workaround for CONST_STRING_DECL #954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore workaround for android initially introduced int apple#622 SwiftJava@6213cba Refix: https://bugs.swift.org/browse/SR-2587 https://bugs.swift.org/browse/SR-2588
|
Given that the mangling changed on ToT, is the same value here still correct? |
|
Hi @parkera But as I see here https://github.com/apple/swift-corelibs-foundation/blob/swift-3.1-RELEASE/build.py#L19 it is changed in master to How to better organize this? |
|
Should I open two PR with different symbols to master and swift-3.1-branch? |
|
Yes, they are different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore workaround for android initially introduced int #622
SwiftJava@6213cba
Refix: https://bugs.swift.org/browse/SR-2587 https://bugs.swift.org/browse/SR-2588