Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/DNM: LLP64 support for SDK Overlay #414

Merged
merged 1 commit into from Nov 5, 2018

Conversation

compnerd
Copy link
Collaborator

If we cannot break the ABI for C++ users of libdispatch, this would
allow us to build the SDK overlay for LLP64 targets.

If we cannot break the ABI for C++ users of libdispatch, this would
allow us to build the SDK overlay for LLP64 targets.
@tkremenek
Copy link
Member

@swift-ci test

@ktopley-apple
Copy link
Contributor

@compnerd - is this an alternative to PR #409?

@compnerd
Copy link
Collaborator Author

compnerd commented Nov 5, 2018

@ktopley-apple, no, not an alternative, it is a supplement to. The problem is that I did not know whether changing the underlying type for dispatch_flags_t is a reasonable option or not. If it is not possible to change the underlying type of the typedef, then this will be needed (which IMO is unfortunate). It also means that using libdispatch on an LLP64 host is difficult. One other option may be to change the ABI for LLP64 hosts, in which case, this patch would not be needed. This is related to the comment #409 (comment)

@ktopley-apple
Copy link
Contributor

@compnerd #409 was just merged. My reading of your reply is that this change should no longer be needed. If that's not the case, please let me know and I'll merge it.

@compnerd
Copy link
Collaborator Author

compnerd commented Nov 5, 2018

@ktopley-apple this change is still needed (as the flag sizes are different across Windows x64 and the other targets).

@ktopley-apple ktopley-apple merged commit bd2367c into apple:master Nov 5, 2018
@compnerd compnerd deleted the llp64-overlay branch November 5, 2018 18:24
rokhinip pushed a commit that referenced this pull request Nov 5, 2021
WIP/DNM: LLP64 support for SDK Overlay

Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants