[5.3][CMake] fix runpath for ELF platforms #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the absolute path to the host stdlib for libswiftDispatch.so and add $ORIGIN to it and libdispatch.so.
|
@swift-ci test |
|
Thanks, it would be good to get this and the equivalent Foundation pull in for the 5.3 release, as user executables link against them and this patch would close a security hole for that. The same XCTest and SPM pulls can wait for the 5.3.1 release, as those are holes when running the toolchain, which I presume is less serious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the absolute path to the host stdlib for libswiftDispatch.so and add $ORIGIN to it and libdispatch.so.
It has been suggested to me by some Swift devs that this would be good to get in before the 5.3 release, a cherry-pick from #541. @compnerd, I can remove the
$ORIGINportions and just make this about removing the toolchain stdlib rpath if you prefer.This should be completely safe for the 5.3 branch, as it's just removing an unused rpath and adding rpaths that are already used, in a more explicit way.