Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.9] Clamp the length for WriteFile calls on win32 pipes. #802

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[5.9] Clamp the length for WriteFile calls on win32 pipes. #802

merged 1 commit into from
Dec 6, 2023

Conversation

ahoppen
Copy link

@ahoppen ahoppen commented Dec 2, 2023

@ahoppen ahoppen mentioned this pull request Dec 2, 2023
Draft
@ahoppen ahoppen changed the title Clamp the length for WriteFile calls on win32 pipes. [5.9] Clamp the length for WriteFile calls on win32 pipes. Dec 2, 2023
tristanlabelle
tristanlabelle approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ahoppen
Copy link
Author

ahoppen commented Dec 4, 2023

Verified that the 5.9 Windows toolchain built with this change does not have the sourcekit-lsp issue.

@ahoppen
Copy link
Author

ahoppen commented Dec 4, 2023

@swift-ci Please test

@ahoppen ahoppen mentioned this pull request Dec 4, 2023
Closed
@compnerd compnerd mentioned this pull request Dec 5, 2023
Closed
@ahoppen ahoppen merged commit 2053307 into apple:release/5.9 Dec 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanlabelle tristanlabelle tristanlabelle approved these changes

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahoppen @tristanlabelle @airspeedswift