Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conditional compilation flags #180

Merged

Conversation

@larryonoff
Copy link
Contributor

larryonoff commented Dec 2, 2016

This a part of PR #176 to simplify base PR.

XCTMain.swift concernes me a lot, but still this file changes look correct for me.

@larryonoff larryonoff mentioned this pull request Dec 2, 2016
0 of 4 tasks complete
#endif

#if os(macOS) || os(Linux) || os(FreeBSD)

This comment has been minimized.

@briancroom

briancroom Dec 2, 2016 Collaborator

What's the motivation for introducing this conditional? Does it fail to build in on other platforms for some reason?

This comment has been minimized.

@larryonoff

larryonoff Dec 5, 2016 Author Contributor

@briancroom thank you for pointing this out. I thought that func XCTMain won't compile for iOS (e.g. since exit method usage), but I was wrong. I just checked and it compiles. So I removed this condition.

@larryonoff larryonoff force-pushed the thaliproject:update-conditional-compilation-flags branch from 3379156 to 7792349 Dec 5, 2016
@larryonoff larryonoff force-pushed the thaliproject:update-conditional-compilation-flags branch from 7792349 to ab67a77 Dec 5, 2016
@briancroom
Copy link
Collaborator

briancroom commented Dec 5, 2016

@swift-ci please test

@briancroom
Copy link
Collaborator

briancroom commented Dec 6, 2016

This looks great! Thanks a lot @larryonoff.

@briancroom briancroom merged commit 242864a into apple:master Dec 6, 2016
2 checks passed
2 checks passed
Swift Test Linux Platform Build finished.
Details
Swift Test OS X Platform Build finished.
Details
@larryonoff larryonoff deleted the thaliproject:update-conditional-compilation-flags branch Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.