update conditional compilation flags #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
briancroom
reviewed
Dec 2, 2016
| #endif | ||
|
|
||
| #if os(macOS) || os(Linux) || os(FreeBSD) |
There was a problem hiding this comment.
What's the motivation for introducing this conditional? Does it fail to build in on other platforms for some reason?
There was a problem hiding this comment.
@briancroom thank you for pointing this out. I thought that func XCTMain won't compile for iOS (e.g. since exit method usage), but I was wrong. I just checked and it compiles. So I removed this condition.
larryonoff
force-pushed
the
update-conditional-compilation-flags
branch
from
3379156
to
7792349
Compare
larryonoff
force-pushed
the
update-conditional-compilation-flags
branch
from
7792349
to
ab67a77
Compare
|
@swift-ci please test |
|
This looks great! Thanks a lot @larryonoff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a part of PR #176 to simplify base PR.
XCTMain.swift concernes me a lot, but still this file changes look correct for me.