Bump the macOS deployment target to 10.13 in the Xcode project. #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
stmontgomery,
rintaro,
briancroom,
SeanROlszewski,
shahmishal and
dennisweissmann
|
@swift-ci please test |
dennisweissmann
approved these changes
Jul 5, 2023
SeanROlszewski
approved these changes
Jul 5, 2023
briancroom
approved these changes
Jul 5, 2023
|
This doesn't appear to solve our 5.9 issue, but it's strictly correct, so I'll go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin. In February, the minimum deployment target for the Swift project at-large was increased to 10.13. This mismatch is now causing build warnings e.g. here: https://ci.swift.org/job/swift-corelibs-foundation-PR-macOS/268/
This PR changes the deployment target of the XCTest Xcode project to match Swift's.