Allow Xcode to highlight failing functional test expectations #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctional tests. This allows Xcode to highlight the failing line in the editor.
|
Very cool. |
|
I tried this out locally, and it's really amazing!! 😍 I wonder if we can improve |
modocache
added a commit
that referenced
this pull request
Mar 13, 2016
Allow Xcode to highlight failing functional test expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of our continuing attempts to improve the quality of the functional test suite, I was hoping to improve the way that the test failure output integrates with Xcode.
Here, I have amended failure output to include the file name and line number where the
// CHECK:line came from. Xcode is able to use this information to mark the line in the editor as containing an error, like so:This makes it easier to diagnose failures in the editor itself, without needing to jump over to the build log to examine the raw output from
xctest_checker