Use Linux Glibc and Foundation on Android #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand the Linux/FreeBSD check to include Android. The "Android" OS will be supported by the next snapshot (which this commit will also be a part of).
|
👍 cool! Looking forward to further progress being made on this in the coming weeks. |
|
Would it be better to write this as special for OS X? I guess arguably we have the same problem there if we consider all the Apple platforms, but, on the other hand, the ability to build this on OS X at all is mostly a convenience for those developing it, so I'm not sure trying to support the other Apple platforms makes much sense anyway... |
|
I agree that OS X is the only Darwin platform that we should be supporting here, so reversing the conditional does seem like a sensible move. |
|
OK, will do soon! 👍 |
|
This is still something I'm interested in doing someday, but I'll close this for now, in order to clean up outstanding pull requests against this repository. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the Linux/FreeBSD check to include Android. The "Android" OS will be supported by the next snapshot (which this commit will also be a part of).
corelibs-xctest won't work on Android yet, even after this change. For it to work, we'll need to port corelibs-foundation as well. Still, consider this a bit of preliminary work.