Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't swift-format pb.swift files, causes unnecessary code churn #84

Closed
ktoso opened this issue Sep 2, 2019 · 3 comments · Fixed by #115
Closed

Don't swift-format pb.swift files, causes unnecessary code churn #84

ktoso opened this issue Sep 2, 2019 · 3 comments · Fixed by #115
Assignees
@drexin
Labels
t:build
Milestone
0.1.0

Comments

@ktoso
Copy link
Member

ktoso commented Sep 2, 2019 •
edited

We format all .swift files, but that's a bit annoying with GeneratedFromProto.pb.swift files which are generated sources.

One has to reformat after every proto generation...

--

Alternative: always triger formatting on proto generated files as part of the generate_protos script.
@ktoso ktoso self-assigned this Sep 2, 2019
@ktoso ktoso added the t:build label Sep 2, 2019
@ktoso ktoso added this to the 0.1.0 milestone Sep 2, 2019
@ktoso
Copy link
Member Author

ktoso commented Sep 2, 2019

Mixed feelings what to do about these...

WDYT @tomerd @drexin ?

I'd normally exclude generated files from formatting completely; WDYT?
(Then the script needs to be changed quite a bit to be file per file, so a bit slower) though, or "be smarter"

@tomerd
Copy link
Member

tomerd commented Sep 3, 2019

excluding generated files seems fine to me

@drexin
Copy link
Member

drexin commented Sep 3, 2019

Yes, +1 on excluding

@drexin drexin mentioned this issue Sep 13, 2019
Merged
@drexin drexin assigned drexin and unassigned ktoso Sep 13, 2019
@drexin drexin added the 3 - in progress Ticket is being worked on label Sep 13, 2019
ktoso pushed a commit that referenced this issue Sep 15, 2019
@drexin @ktoso
Exclude protobuf generated sources from swiftformat #84 (#115)
1a0bf2c
@ktoso ktoso removed the 3 - in progress Ticket is being worked on label Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drexin drexin

Labels
t:build
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Exclude protobuf generated sources from swiftformat #84 drexin/swift-distributed-actors.legacy
3 participants
@ktoso @tomerd @drexin