Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withSpan overloads for automatic context propagation #55

Closed
Tracked by #54
slashmo opened this issue Aug 11, 2021 · 0 comments · Fixed by #52
Closed
Tracked by #54

Add withSpan overloads for automatic context propagation #55

slashmo opened this issue Aug 11, 2021 · 0 comments · Fixed by #52
Assignees
Milestone

Comments

@slashmo
Copy link
Collaborator

slashmo commented Aug 11, 2021

We should add withSpan overloads which take no Baggage argument, and instead use the task local Baggage.current. We'll need one synchronous and one async version (at least until reasync was added to the language). These overloads should execute the given operation within a child task where Baggage.$current is bound to the newly created span's Baggage. That way spans started within that operation will automatically become children of the outer span (depending on the tracer implementation).

@slashmo slashmo added the 3 - in progress This task is being worked on; It may or may not yet have an associated PR label Aug 11, 2021
@slashmo slashmo added this to the 0.2.0 milestone Aug 11, 2021
@slashmo slashmo self-assigned this Aug 11, 2021
@slashmo slashmo removed the 3 - in progress This task is being worked on; It may or may not yet have an associated PR label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant