-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dependency-free Baggage module #52
Conversation
@tomerd Regarding CI we'd need the same update as for the Baggage repo. Remove 5.0 & 5.1 and add 5.4 & 5.5 instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I'll get CI sorted out once California wakes up and I can poke some folks :)
@yim-lee Looks like in this repo 5.4 & 5.5 are not yet required to pass by the branch protection rules. Could you please add that in as well? |
Seems to me we could merge this? |
The 5.5 CI failed due to the Ruby version not being high enough to install Jazzy:
CC @ktoso |
@@ -8,7 +8,7 @@ let package = Package( | |||
.library(name: "Tracing", targets: ["Tracing"]), | |||
], | |||
dependencies: [ | |||
.package(url: "https://github.com/apple/swift-distributed-tracing-baggage.git", from: "0.2.0"), | |||
.package(url: "https://github.com/apple/swift-distributed-tracing-baggage.git", .upToNextMinor(from: "0.2.0")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do this in a library.
The current issue is just an outcome that we're removing/breaking Apis because all this is pre 1.x, it's not something we need to future guard against.
very weird with that docker issue... I'll look into it with @yim-lee in the morning |
Sorry I missed this. I've made 5.4 and 5.5 required as well. FYI branch rules can be updated by any GH repo admin.
This is not specific to Swift 5.5 actually. One can reproduce it locally if they build the docker image with To fix the problem, either do what the error message suggests and update In case it helps, this mimics what CI does:
|
@yim-lee Thanks! Specifying the version explicitly works 👍 |
withSpan
overloads for automatic context propagation #55