Add Span.updateAttributes #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashmo
approved these changes
Sep 6, 2023
slashmo
force-pushed
the
af-update-attributes
branch
from
735ccce
to
fe5dc71
Compare
Co-authored-by: Moritz Lang <hi@slashmo.codes>
Co-authored-by: Moritz Lang <hi@slashmo.codes>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating span attributes requires some form of thread synchronisation. If you update each attribute individually this could have a performance hit. This PR adds
Span.updateAttributeswhich provides a way to update attributes in one go and only pay for the thread synchronisation costs once.