Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining Otel (0.7.0) semantic attributes #38

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Add remaining Otel (0.7.0) semantic attributes #38

merged 2 commits into from
Jan 27, 2021

Conversation

slashmo
Copy link
Collaborator

@slashmo slashmo commented Jan 26, 2021

This PR is part of the effort to be on par with Otel 0.7.0 (#32). It adds the remaining semantic span attributes and updates existing ones. All documentation comments pointing towards Otel have been updated to point to the specific 0.7.0 version on GitHub.

@slashmo slashmo requested a review from ktoso January 26, 2021 15:20
@slashmo slashmo self-assigned this Jan 26, 2021
@slashmo
Copy link
Collaborator Author

slashmo commented Jan 26, 2021

@ktoso / @tomerd: I'm not sure why the CI is failing here, seems to be something wrong with Jenkins:

java.io.FileNotFoundException: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.275.b01-0.el7_9.x86_64/jre/lib/currency.data (No such file or directory)

@ktoso
Copy link
Member

ktoso commented Jan 27, 2021

@swift-server-bot test this please

Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Can you mass change the - See to - SeeAlso and merge? 👍

CI just had some hiccups, builds ok now :-)

@ktoso
Copy link
Member

ktoso commented Jan 27, 2021

Does this completely resolve #32 or still some things to check?

@slashmo
Copy link
Collaborator Author

slashmo commented Jan 27, 2021

Does this completely resolve #32 or still some things to check?
@ktoso

I think it depends on whether we want to add some kind of Resource (#39). If so, I'd include it in #32 as well. Otherwise, I'd have to look through the spec once more but I think we're already on par with Otel 0.7.0.

Co-authored-by: Konrad `ktoso` Malawski <ktoso@apple.com>
@slashmo slashmo merged commit fce1f7c into apple:main Jan 27, 2021
@slashmo slashmo deleted the update/otel-semantic-span-attributes branch January 27, 2021 09:17
@slashmo slashmo added this to the 0.1.4 milestone Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants