+span additional withSpan to ease entering async world from non-async world #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashmo
approved these changes
Aug 19, 2022
Sources/Tracing/Tracer.swift
Outdated
| /// - Throws: the error the `operation` has thrown (if any) | ||
| public func withSpan<T>( | ||
| _ operationName: String, | ||
| baggage: Baggage?, |
There was a problem hiding this comment.
To keep it more consistent with the synchronous counterpart of this withSpan, I'd make baggage a non-optional required parameter. If folks wanna start top-level let's make it obvious they do so.
There was a problem hiding this comment.
Nice catch, thank you!
And I'll fix the old swift issues.
ktoso
force-pushed
the
wip-additional-withSpan
branch
from
deb480c
to
03af4c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wondering if we need to offer this.
Just an idea for now, but I've hit this when calling swift code from C, where we could not have had set the task-local, so here we're "entering the async world". We could set the
Baggagearound the withSpan, but that means two levels of nesting and one task local set more than we actually need.