Allow for reading and mutating a span name #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If unsure about this feature, please check the #48 discussion and otel's justification which I think is reasonable https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#updatename |
ktoso
force-pushed
the
wip-mutableOperation-name
branch
from
7896e98
to
3283a47
Compare
**Motivation:** The feature frozen otel specification allows for renaming spans after they have been started. This often is too late to impact sampling decisions, however we still can use to to provide better names for spans as time goes on. **Modifications:** add an operationName to the Span protocol. A span has to be thread-safe already and we have mutating operations on it already so it does not change the complexity requirements on implementing a span. **Result:** Be closer to otel spec and more flexible in naming and renaming spans. Resolves #48
ktoso
force-pushed
the
wip-mutableOperation-name
branch
from
3283a47
to
c7e646b
Compare
ktoso
changed the title
stevapple
reviewed
Feb 26, 2023
ktoso
commented
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The feature frozen otel specification allows for renaming spans after they have been started. This often is too late to impact sampling decisions, however we still can use to to provide better names for spans as time goes on.
Modifications:
add an operationName to the Span protocol.
A span has to be thread-safe already and we have mutating operations on it already so it does not change the complexity requirements on implementing a span.
Result:
Be closer to otel spec and more flexible in naming and renaming spans.
Resolves #48