Adapt Symbol Graph Format to Changes Introduced in apple/swift#59047 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theMomax
force-pushed
the
extension-block-symbols-compatibility
branch
from
825f08f
to
77674b7
Compare
theMomax
force-pushed
the
extension-block-symbols-compatibility
branch
from
77674b7
to
b1563be
Compare
4 tasks
franklinsch
reviewed
Jul 14, 2022
3 tasks
…ocus on encoding/decoding the mixin, instead of the whole symbol
franklinsch
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Looks great to me, thanks! @QuietMisdreavus anything from your end?
|
@swift-ci please test |
QuietMisdreavus
approved these changes
Jul 22, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: swiftlang/swift#59047, apple/swift-docc#210
Summary
This PR introduces the new
swift.extensionSymbol Kind and theextensionToRelationship Kind. In addition, it adds an optionaltypeKindfield to theSwift.ExtensionMixin.These adaptions are necessary so that the
-emit-extension-block-symbolsformat introduced in swiftlang/swift#59047 can be parsed properly.Dependencies
swiftlang/swift#59047
Testing
There is a new unit test for decoding
Swift.Extension's optionaltypeKindproperty.The following files were produced with the
-emit-extension-block-symbolsmode from swiftlang/swift#59047. Those and the old format should be decoded and re-encoded without errors or warnings.Symbol Graph Files.zip
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded