MergeStrategy with ExtensionGraphAssociation Option for GraphCollector #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theMomax
changed the title
- introduce ExtensionGraphAssociation option defining if extension graphs are merged with the extending or extended graph - add unit-test testing ExtensionGraphAssociation behavior
theMomax
force-pushed
the
flexible-graph-merging
branch
from
ae26406
to
c6e680f
Compare
3 tasks
|
@swift-ci Please test |
QuietMisdreavus
approved these changes
Jul 22, 2022
|
@swift-ci Please test |
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adaption is required to fix apple/swift-docc#210
Summary
Adds a strategy option to
GraphCollector's init. TheExtensionGraphAssociationoption decides if extension graphs are merged with the extending or extended graph.Dependencies
This PR does not introduce a breaking change and can be merged independently.
Testing
I added a new unit test to test the merging behavior for both ExtensionGraphAssociation options.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded