Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the cache based link resolver #624

Merged
merged 5 commits into from Jul 7, 2023

Conversation

d-ronnqvist
Copy link
Contributor

Bug/issue #, if applicable:

Summary

This removes the cache based link resolver in favor of the (default) hierarchy based link resolver.

It also cleans up a few small pieces in the documentation context that dealt with behavior specific to the cache based link resolver that are now unused.

Note:
This change is only intended for the "main" branch. The cache based link resolver should remain an opt-in alternative in the 5.9 release.

Dependencies

None

Testing

Nothing specific to test. The hierarchy based link resolver was already the default and everything should continue to behave the same as before.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • [ ] Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

Copy link
Collaborator

@Kyle-Ye Kyle-Ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing clean up 👍

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit accb0b0 into apple:main Jul 7, 2023
2 checks passed
@d-ronnqvist d-ronnqvist deleted the remove-old-link-resolver branch July 7, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants