Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optionalMemberOf symbol under the correct container symbol #760

Merged

Conversation

d-ronnqvist
Copy link
Contributor

@d-ronnqvist d-ronnqvist commented Dec 5, 2023

Bug/issue #, if applicable: rdar://119183922

Summary

Fix a bug where optionalMemberOf relationships weren't considered when building the path hierarchy, resulting in incorrect behavior if more than one symbol exist with the container's name.

Dependencies

None

Testing

Describe how a reviewer can test the functionality of your PR. Provide test content to test with if
applicable.

Steps:

  1. Provide setup instructions.
  2. Explain in detail how the functionality can be tested.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • [ ] Updated documentation if necessary

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 02718ca into apple:main Dec 5, 2023
2 checks passed
@d-ronnqvist d-ronnqvist deleted the optional-member-of-ambiguous-container branch December 5, 2023 15:30
d-ronnqvist added a commit to d-ronnqvist/swift-docc that referenced this pull request Dec 7, 2023
d-ronnqvist added a commit to d-ronnqvist/swift-docc that referenced this pull request Dec 7, 2023
d-ronnqvist added a commit to d-ronnqvist/swift-docc that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants