Create discovered dependencies file for emit-module jobs #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit-module jobs might have different discovered dependencies and run in a different context where they need to get invalidated separately from the compile jobs. With the new key "emit-module-dependencies" in the output file map the build system can specify that it expects a makefile-style dependency file at the given path. rdar://91574616
|
@swift-ci please test |
owenv
approved these changes
Apr 12, 2022
|
I think something is wrong with this pull, as I've been seeing a bunch of but when translated to the which causes all those files to be dumped in the top level of the package, rather than in Update: I can reproduce with the just-released Apr. 20 trunk snapshot for Ubuntu too, with the same workaround making it go away, implying the bug is definitely in this repo. |
|
@buttaface thanks for identifying the change. I’ve been seeing this on Windows as well. |
compnerd
added a commit
to compnerd/swift-driver
that referenced
this pull request
May 1, 2022
Provide a fallback default for the `emit-module.d` file. It has been observed on Windows and Android that builds subsequent to swiftlang#1056 would emit files into the root of the source tree (specifically, `pwd`). If there is no explicit location specified for the new output, and given that there is no primary output associated with the command, the path that defaults is simply a singular file name component, emitting that file into the location that the driver was executed from (which comes out to the root of the package for commandline invocations), dirtying the source tree. Rather than sinking the knowledge for the default into `existingOutputForSingleInput`, where we have no access to the module name, emit the logic inline and derive a name based on the Swift module and place it as a peer. This should help ensure that the serialized diagnostics do not end up committed accidentally.
compnerd
added a commit
to compnerd/swift-driver
that referenced
this pull request
May 4, 2022
Provide a fallback default for the `emit-module.d` file. It has been observed on Windows and Android that builds subsequent to swiftlang#1056 would emit files into the root of the source tree (specifically, `pwd`). If there is no explicit location specified for the new output, and given that there is no primary output associated with the command, the path that defaults is simply a singular file name component, emitting that file into the location that the driver was executed from (which comes out to the root of the package for commandline invocations), dirtying the source tree. Rather than sinking the knowledge for the default into `existingOutputForSingleInput`, where we have no access to the module name, emit the logic inline and derive a name based on the Swift module and place it as a peer. This should help ensure that the serialized diagnostics do not end up committed accidentally.
artemcm
pushed a commit
to artemcm/swift-driver
that referenced
this pull request
May 23, 2022
Provide a fallback default for the `emit-module.d` file. It has been observed on Windows and Android that builds subsequent to swiftlang#1056 would emit files into the root of the source tree (specifically, `pwd`). If there is no explicit location specified for the new output, and given that there is no primary output associated with the command, the path that defaults is simply a singular file name component, emitting that file into the location that the driver was executed from (which comes out to the root of the package for commandline invocations), dirtying the source tree. Rather than sinking the knowledge for the default into `existingOutputForSingleInput`, where we have no access to the module name, emit the logic inline and derive a name based on the Swift module and place it as a peer. This should help ensure that the serialized diagnostics do not end up committed accidentally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit-module jobs might have different discovered dependencies and run in a different context where they need to get invalidated separately from the compile jobs.
With the new key "emit-module-dependencies" in the output file map the build system can specify that it expects a makefile-style dependency file at the given path.
rdar://91574616