Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase use of 'guard let' not supported by older compilers. #1233

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Dec 1, 2022

'guard let X else {}' works with latest Swift compilers (such as one used in swift-driver CI) but isn't supported in some older compilres used in CI and other bots.

'guard let X else {}' works with latest Swift compilers (such as one used in swift-driver CI) but isn't supported in some older compilres used in CI and other bots.
@artemcm
Copy link
Contributor Author

artemcm commented Dec 1, 2022

@swift-ci test

artemcm referenced this pull request Dec 1, 2022
…as incremental build state

On an incremental build, load a prior dependency graph, check if it is still valid:
1. import set of the current module has not changed
2. input files of every module in the prior graph are older than the output
and if it is, re-use it, skipping invoking the dependency scanner again.

Partially resolves rdar://66801475
Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants