Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated file note to Options.swift #1330

Merged
merged 2 commits into from Apr 13, 2023

Conversation

etcwilde
Copy link
Member

Updating makeOptions to include note that options.swift is generated so it should not be edited by hand.

Adding a note to the file so that folks are reminded not to edit it by hand.

Updating makeOptions to include note that options.swift is generated so
it should not be edited by hand.
@etcwilde etcwilde requested a review from artemcm April 12, 2023 18:36
@etcwilde
Copy link
Member Author

@swift-ci please test

@etcwilde
Copy link
Member Author

I should probably add the generated header comment to Options.swift.

Updating the Option.swift header with the new generated comment
@etcwilde
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank youuuuuu

@etcwilde
Copy link
Member Author

@swift-ci please test Windows

@etcwilde etcwilde merged commit a234bef into apple:main Apr 13, 2023
3 checks passed
@etcwilde etcwilde deleted the ewilde/generated-file-note branch April 13, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants