Use DarwinToolchain for apple-none targets #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rauhul
commented
Apr 14, 2023
rauhul
commented
- When compiling for os none for apple, we should perfer using a Darwin toolchain (maybe a misnomer now) instead of a generic UNIX toolchain. This results in the driver selecting relevant tools for apple platforms, such as using ld64 over gold, etc.
artemcm
approved these changes
Apr 14, 2023
compnerd
approved these changes
Apr 14, 2023
| return GenericUnixToolchain.self | ||
| case .wasi: | ||
| return WebAssemblyToolchain.self | ||
| case .win32: | ||
| return WindowsToolchain.self | ||
| case .noneOS: | ||
| switch self.vendor{ |
There was a problem hiding this comment.
Suggested change
| switch self.vendor{ | |
| switch self.vendor { |
There was a problem hiding this comment.
Picked up this diff with the latest commit that adds tests. I used a large list of triples already used in TripleTests, but I'm not sure if this is really the best test structure and I'm happy to change it if you have any ideas.
There was a problem hiding this comment.
I appreciate the thoroughness. It looks good to me, thanks!
- When compiling for os none for apple, we should perfer using a Darwin toolchain (maybe a misnomer now) instead of a generic UNIX toolchain. This results in the driver selecting relevant tools for apple platforms, such as using ld64 over gold, etc.
rauhul
force-pushed
the
apple-none-isnt-unix
branch
from
f3fd0e6
to
446c9b9
Compare
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
|
kubamracek
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.