In WMO, make sure the dummy "primary" compilation input is a Swift source file #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce file Otherwise, if the first argument is anything else (e.g. an object file) we will use it as a key and the compiler won't be too happy about that. Resolves rdar://108741675
|
@swift-ci test |
etcwilde
reviewed
May 1, 2023
| @@ -585,7 +585,10 @@ extension Driver { | |||
| // To match the legacy driver behavior, make sure we add the first input file | |||
| // to the output file map if compiling without primary inputs (WMO), even | |||
| // if there aren't any corresponding outputs. | |||
| entries[inputFiles[0].fileHandle] = [:] | |||
| guard let firstSourceInputHandle = inputFiles.first(where:{ $0.type == .swift })?.fileHandle else { | |||
| fatalError("Formulating swift-frontend invocation without any input .swift files") | |||
There was a problem hiding this comment.
I think I can hit this fatalError, though honestly, if we're even formulating FrontendJobs when we don't have any source inputs, something has probably gone wrong before this point.
There was a problem hiding this comment.
My thinking is that, if anything, this will help catch such issues early. This code-path should not otherwise be taken if we don't have any source inputs, I don't think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if the first argument is anything else (e.g. an object file) we will use it as a key and the compiler won't be too happy about that.
Resolves rdar://108741675