Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable adding '-external-plugin-path' in integrated driver mode #1356

Merged
merged 2 commits into from May 9, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 8, 2023

rdar://109060298

@rintaro
Copy link
Member Author

rintaro commented May 8, 2023

@swift-ci Please test

@artemcm
Copy link
Contributor

artemcm commented May 8, 2023

@rintaro could you please add a quick test that ensures Driver instantiated with this bit set does not add the flags?

@rintaro rintaro force-pushed the external-plugin-path-rdar109060298 branch from bf2de71 to 9154926 Compare May 8, 2023 22:46
rdar://109060298
@rintaro rintaro force-pushed the external-plugin-path-rdar109060298 branch from 9154926 to c75cfd4 Compare May 8, 2023 22:47
@rintaro
Copy link
Member Author

rintaro commented May 8, 2023

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented May 9, 2023

@swift-ci Please test Windows

@rintaro rintaro merged commit d8a3480 into apple:main May 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants