Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unicode chars in package-name in driver #1367

Merged
merged 1 commit into from May 31, 2023
Merged

Allow unicode chars in package-name in driver #1367

merged 1 commit into from May 31, 2023

Conversation

elsh
Copy link
Contributor

@elsh elsh commented May 30, 2023

Frontend allows unicode chars in package-name. This PR follows the same rule in the driver for consistency.
Resolves rdar://110021211

@elsh elsh requested a review from artemcm May 30, 2023 20:08
@elsh
Copy link
Contributor Author

elsh commented May 30, 2023

@swift-ci test

@elsh elsh requested a review from tshortli May 30, 2023 20:10
elsh added a commit that referenced this pull request May 30, 2023
@elsh
Description: Allow unicode chars in package-name in driver.
9049e6a 
Frontend already allows them but the same change was not made in
driver. This PR fixes that for consistency.
Risk: Low. Frontend already allows unicode chars.
Original PR: #1367
Reivewers: @artemcm
Testing: Modified an existing test to allow unicode chars in package-name
Resolves: rdar://110021211
@elsh elsh mentioned this pull request May 30, 2023
Merged
elsh added a commit that referenced this pull request May 30, 2023
@elsh
Description: Allow unicode chars in package-name in driver.
35ec2b9 
    Frontend already allows them but the same change was not made in
    driver. This PR fixes that for consistency.
    Risk: Low. Frontend already allows unicode chars.
    Original PR: #1367
    Reivewers: @artemcm
    Testing: Modified existing tests
    Resolves: rdar://110021211
@elsh
Copy link
Contributor Author

elsh commented May 30, 2023

@swift-ci test

@elsh
Copy link
Contributor Author

elsh commented May 31, 2023

@swift-ci test windows

@elsh elsh merged commit f66dd67 into main May 31, 2023
3 checks passed
@elsh elsh deleted the es-pkg-uni branch May 31, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@tshortli tshortli tshortli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elsh @artemcm @tshortli