Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftDriver: mark bitcode interfaces as internal #1376

Merged
merged 1 commit into from Jun 14, 2023

Conversation

compnerd
Copy link
Collaborator

We do not vend the bitcode reading as an API that others may use. Mark this as internal as the interfaces are used strictly within the IncrementalCompilation module. If we need, we can extend in the further to use @package visibility.

We do not vend the bitcode reading as an API that others may use.  Mark
this as `internal` as the interfaces are used strictly within the
`IncrementalCompilation` module.  If we need, we can extend in the
further to use `@package` visibility.
@compnerd compnerd requested a review from artemcm June 13, 2023 22:37
@compnerd
Copy link
Collaborator Author

@swift-ci please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thank you!

@compnerd compnerd merged commit c8e3c84 into apple:main Jun 14, 2023
3 checks passed
@compnerd compnerd deleted the internal branch June 14, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants