Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.9] Remove unused runtime library path on non-Darwin platforms #1381

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

finagolfin
Copy link
Contributor

Cherrypick of #1374

Explanation: As detailed in the linked issue, the compiler currently looks in /sdk/usr/lib/swift/ if an -sdk is explicitly specified, which may be needed for Darwin platforms, but is unused on non-Darwin.

Scope: Only affects an unused library path on non-Darwin platforns

Issue: apple/swift#63416

Risk: low, as nobody appears to use it

Testing: Passed all CI on trunk

Reviewer: @artemcm

@finagolfin
Copy link
Contributor Author

Ping @artemcm, can we get this in?

@artemcm artemcm requested a review from nkcsgexi June 27, 2023 15:27
@artemcm
Copy link
Contributor

artemcm commented Jun 27, 2023

@swift-ci test

@artemcm artemcm merged commit 216ba83 into apple:release/5.9 Jun 28, 2023
3 checks passed
@finagolfin finagolfin deleted the release/5.9 branch June 29, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants