Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver: allow static executables when using Musl #1383

Merged
merged 3 commits into from Jul 5, 2023
Merged

Driver: allow static executables when using Musl #1383

merged 3 commits into from Jul 5, 2023

Conversation

MaxDesiatov
Copy link
Member

This error diagnostic doesn't make sense when linking on Linux with Musl, which allows fully statically linked executables.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Jun 20, 2023
@MaxDesiatov MaxDesiatov requested a review from artemcm June 20, 2023 09:23
@MaxDesiatov MaxDesiatov self-assigned this Jun 20, 2023
@MaxDesiatov
Copy link
Member Author

@swift-ci test

al45tair
al45tair reviewed Jun 21, 2023
View reviewed changes
Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me; I wonder whether Triple should grow a supportsStaticExecutables property though, rather than explicitly testing for .musl in here?

@MaxDesiatov
Copy link
Member Author

@swift-ci test

al45tair
al45tair approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MaxDesiatov
Copy link
Member Author

@swift-ci test windows

@rauhul
Copy link
Contributor

rauhul commented Jun 21, 2023

Seems reasonable to me; I wonder whether Triple should grow a supportsStaticExecutables property though, rather than explicitly testing for .musl in here?

+100, I was planning on adding a supportsDynamicExecutables to handle os(none)

@MaxDesiatov
Copy link
Member Author

Not merging this yet as I want to add a test or two that cover this.

@MaxDesiatov
Copy link
Member Author

@swift-ci test

@MaxDesiatov MaxDesiatov merged commit 256c95c into main Jul 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al45tair al45tair al45tair approved these changes

@artemcm artemcm artemcm approved these changes

@etcwilde etcwilde Awaiting requested review from etcwilde

Assignees

@MaxDesiatov MaxDesiatov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MaxDesiatov @rauhul @al45tair @artemcm