Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Driver] For immediate mode prefer using the default SDK over the SDKROOT variable #1390

Merged

Conversation

akyrtzi
Copy link
Member

@akyrtzi akyrtzi commented Jul 4, 2023

Avoid using SDKROOT because that may be set to a compilation platform (like iOS) that is different than the host. For immediate mode the host SDK is what needs to be used.

…KROOT` variable

Avoid using `SDKROOT` because that may be set to a compilation platform (like iOS) that is different than the host.
For immediate mode the host SDK is what needs to be used.
@akyrtzi
Copy link
Member Author

akyrtzi commented Jul 4, 2023

@swift-ci Please test

@akyrtzi akyrtzi requested a review from lhames July 4, 2023 18:07
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@akyrtzi akyrtzi merged commit bb3fdfe into apple:main Jul 5, 2023
3 checks passed
@akyrtzi akyrtzi deleted the akyrtzi/pr/ignore-SDKROOT-for-immediate branch July 5, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants