Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Options] Fix makeOptions after upstream Option TableGen change #1429

Merged

Conversation

cachemeifyoucan
Copy link
Contributor

Generate correct Options.swift from new option tablegen output format after https://reviews.llvm.org/D157029.

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Copy link
Member

@jansvoboda11 jansvoboda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

Generate correct `Options.swift` from new option tablegen output format
after https://reviews.llvm.org/D157029.
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@cachemeifyoucan
Copy link
Contributor Author

Windows test actually passed here: https://ci-external.swift.org/job/swift-driver-PR-windows/563/
But it is not reported, now all the nodes are offline.

@cachemeifyoucan cachemeifyoucan merged commit b202171 into apple:main Aug 29, 2023
3 checks passed
@cachemeifyoucan cachemeifyoucan deleted the eng/PR-makeOptions-D157029-fix branch August 29, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants