Improve swift-driver test cases to avoid fatal crash #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid `try!` that can crash the tests unnecessarily in a throwable context that can just handle the error.
Testcase can be deinit without calling `setUp` in case of something fatal happens. This will cause unwrapping nil during tests if running tests with `--parallel`.
|
@swift-ci please test |
compnerd
approved these changes
Sep 5, 2023
artemcm
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 to fix #1431
try!: if in the throwable context, just usetry. There are two remaining inconcurrentPerformthat would be good to be removed in the future, the rest are in setup/generic tests, that are probably file.--parallel