[5.10] Don't add an autolink-extract job unless actually linking ELF/Wasm objects, matching the original C++ driver #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects, matching the original C++ driver
artemcm
approved these changes
Nov 10, 2023
|
@swift-ci test |
|
Ping, another CI run and then this can go in? |
|
@bnbarham, can I get another CI run here? |
|
@swift-ci please test |
|
@artemcm, one more CI run needed here. |
|
@swift-ci test |
|
@bnbarham, this is ready for merge, can you review and get it in? |
|
Great to see you in here @finagolfin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #1479
Explanation: This driver has long run
autolink-extracteven when it wasn't linking, which the old C++ driver didn't. Get the two matched up.Scope: Compilation jobs that don't link don't need autolink
Issue: none
Risk: none, this was superfluous
Testing: Tested this on trunk with the newly enabled early swift driver tests on the linux CI, no problem.
Reviewer: @artemcm