Jobs: permit bitcode items when building with LTO #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building an archive, permit the LLVM bitcode content into the archive as the LTO path will add those. This should ensure that we can continue to experiment with the LTO optimizations.
|
@buttaface could you please verify that this resolves the issue(s) you have been seeing? |
|
@swift-ci please test |
|
I do not mess with LTO, I only raised the issue of bitcode because I noticed that the old C++ Driver allowed it. You all know better with the LTO stuff, I was just raising the possibility of including it in #773. |
|
This change got merged already in: #858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building an archive, permit the LLVM bitcode content into the
archive as the LTO path will add those. This should ensure that we can
continue to experiment with the LTO optimizations.