Minor updates and corrections to SE-0305 #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abertelrud
commented
Apr 2, 2021
abertelrud
commented
- removed language suggesting that names of triples would commonly also be used as variant names (this can cause confusion about whether that name is significant, and does not work well when multiple triples are supported)
- clarified that name lookup is case sensitive but that archives should not use pairs of names that differ only in case, because such pairs of directory entries cannot coexist on case-insensitive file systems
- added the example of universal binaries as a case in which multiple target triples might be supported by one variant
- small language fixes
- removed language suggesting that names of triples would commonly also be used as variant names (this can cause confusion about whether that name is significant, and does not work well when multiple triples are supported) - clarified that name lookup is case sensitive but that archives should not use pairs of names that differ only in case, because such pairs of directory entries cannot coexist on case-insensitive file systems - added the example of universal binaries as a case in which multiple target triples might be supported
tomerd
approved these changes
Apr 2, 2021
tomerd
approved these changes
Apr 13, 2021
tomerd
reviewed
Apr 13, 2021
…ich don't have architectures
…factbundle" and ".ari" to ".artifactbundleindex". Also clean up occurrences of double whitespaces after periods.
tomerd
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.