Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Proposal to Deprecate @UIApplicationMain and @NSApplicationMain #1881

Merged
merged 5 commits into from Jan 4, 2023
Merged

Add Proposal to Deprecate @UIApplicationMain and @NSApplicationMain #1881

merged 5 commits into from Jan 4, 2023

Conversation

CodaFi
Copy link
Member

@CodaFi CodaFi commented Dec 14, 2022

@rjmccall rjmccall changed the title Add Proposal to Deprecate Framework-Specific Attributes Add Proposal to Deprecate @UIApplicationMain and @NSApplicationMain Jan 4, 2023
rjmccall
rjmccall requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Language Workgroup thinks this has been adequately pitched, and I'll be acting as the review manager. I have some editorial suggestions for the proposal document, but if you can get those in place, I'll go ahead and get this started in the next few days.

proposals/NNNN-deprecate-uiapplicationmain-and-nsapplicationmain.md Outdated Show resolved Hide resolved
proposals/NNNN-deprecate-uiapplicationmain-and-nsapplicationmain.md Outdated Show resolved Hide resolved
proposals/NNNN-deprecate-uiapplicationmain-and-nsapplicationmain.md Outdated Show resolved Hide resolved
proposals/NNNN-deprecate-uiapplicationmain-and-nsapplicationmain.md Outdated Show resolved Hide resolved
proposals/NNNN-deprecate-uiapplicationmain-and-nsapplicationmain.md Outdated Show resolved Hide resolved
proposals/NNNN-deprecate-uiapplicationmain-and-nsapplicationmain.md Outdated Show resolved Hide resolved
proposals/NNNN-deprecate-uiapplicationmain-and-nsapplicationmain.md Outdated Show resolved Hide resolved
proposals/NNNN-deprecate-uiapplicationmain-and-nsapplicationmain.md Outdated Show resolved Hide resolved
proposals/NNNN-deprecate-uiapplicationmain-and-nsapplicationmain.md Outdated Show resolved Hide resolved
@CodaFi CodaFi force-pushed the mcmainerberry branch 4 times, most recently from c02e506 to 12728b3 Compare January 4, 2023 02:55
@CodaFi
Copy link
Member Author

CodaFi commented Jan 4, 2023

Thanks for the review, I've applied your remarks nearly verbatim, and expanded a few sections as appropriate.

@rjmccall rjmccall merged commit 8cd6995 into apple:main Jan 4, 2023
@CodaFi CodaFi deleted the mcmainerberry branch January 4, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmccall rjmccall rjmccall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@CodaFi @rjmccall