Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision to package access proposal #1992

Merged
merged 9 commits into from Mar 30, 2023
Merged

Revision to package access proposal #1992

merged 9 commits into from Mar 30, 2023

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Mar 22, 2023

  • Add to future directions: sub-packages/opt-out of package boundary
  • Updates to package name input string
  • Remove @usableFromPackageInline as it's unnecessary

@elsh elsh changed the title Revision to package acl proposal Revision to package access proposal Mar 23, 2023
@elsh elsh requested a review from neonichu March 23, 2023 02:23
@elsh
Revision to package acl proposal
0db4439 
* Add to future directions: sub-packages/opt-out of package boundary
* Updates to package name input string
* Remove @usableFromPackageInline as it's unnecessary
rjmccall
rjmccall requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the previous revision in the header.

Please discuss @usableFromPackageInline in Alternatives Considered.

proposals/0386-package-access-modifier.md Outdated Show resolved Hide resolved
proposals/0386-package-access-modifier.md Outdated Show resolved Hide resolved
proposals/0386-package-access-modifier.md Outdated Show resolved Hide resolved
proposals/0386-package-access-modifier.md Outdated Show resolved Hide resolved
@elsh
Add prev revision
6ca8671 
Update package name string section
Add group to allow opt-out / subpackages
allevato
allevato reviewed Mar 24, 2023
View reviewed changes
proposals/0386-package-access-modifier.md Outdated Show resolved Hide resolved
proposals/0386-package-access-modifier.md Outdated Show resolved Hide resolved
rjmccall
rjmccall reviewed Mar 28, 2023
View reviewed changes
proposals/0386-package-access-modifier.md Outdated Show resolved Hide resolved
proposals/0386-package-access-modifier.md Outdated Show resolved Hide resolved
proposals/0386-package-access-modifier.md Outdated Show resolved Hide resolved
elsh and others added 3 commits March 28, 2023 16:00
@elsh @rjmccall
Update proposals/0386-package-access-modifier.md
5b8075f 
Co-authored-by: John McCall <rjmccall@apple.com>
@elsh @rjmccall
Update proposals/0386-package-access-modifier.md
c25c40c 
Co-authored-by: John McCall <rjmccall@apple.com>
@elsh @rjmccall
Update proposals/0386-package-access-modifier.md
b421bbf 
Co-authored-by: John McCall <rjmccall@apple.com>
@rjmccall rjmccall merged commit 31c30ea into main Mar 30, 2023
@ktoso ktoso deleted the es-pkg-update branch March 31, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu left review comments

@allevato allevato allevato left review comments

@rjmccall rjmccall rjmccall approved these changes

@xymus xymus Awaiting requested review from xymus

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@elsh @neonichu @rjmccall @allevato