Task executor preference #2187
Merged
Task executor preference #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Oct 25, 2023
weissi
reviewed
Oct 25, 2023
PsychoH13
reviewed
Oct 31, 2023
ktoso
commented
Oct 31, 2023
ktoso
force-pushed
the
wip-task-executors
branch
from
5bdfc48
to
1bef6aa
Compare
FranzBusch
reviewed
Nov 1, 2023
| The `TaskExecutor` is defined as: | ||
|
|
||
| ```swift | ||
| public protocol TaskExecutor: Executor { |
There was a problem hiding this comment.
I think we should provide some docs here on what is allowed. A TaskExecutor is allowed to be a pool of threads or a single thread. Both of them are fine and we should call it out on the docs.
Fixed a little typo
jaredgrubb
reviewed
Nov 2, 2023
ktoso
changed the title
|
I believe this is ready for review now -- the forums thread on pitch also has calmed down, and implementation is almost complete -- only cleanups remain |
DougGregor
reviewed
Dec 4, 2023
DougGregor
reviewed
Dec 4, 2023
ktoso
commented
Dec 5, 2023
Co-authored-by: Doug Gregor <dgregor@apple.com>
rjmccall
reviewed
Dec 12, 2023
Co-authored-by: John McCall <rjmccall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polishing up details here.
Has some inter-play with both typed-throws and #2174 which are not included here but it attempts to be stand-alone.